Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features Request] Various Improvements #6

Open
4 of 5 tasks
VoidSec opened this issue Nov 4, 2022 · 9 comments
Open
4 of 5 tasks

[Features Request] Various Improvements #6

VoidSec opened this issue Nov 4, 2022 · 9 comments

Comments

@VoidSec
Copy link
Contributor

VoidSec commented Nov 4, 2022

Hi, I've "compiled" a list of IMHO useful improvements for the plugin. I'd also like to offer my support in coding some of them (namely #1, #4 and #5) for which I'll try to make PRs in the upcoming days.

Quality of life:

Missing Rules:

Windows Rules:

  • Add "dangerous" Windows API/Windows-related vulnerabilities

PS: feel free to split them into specific issues we can address or rework any of those items. :)

@Martyx00
Copy link
Contributor

Martyx00 commented Nov 4, 2022

HI, thanks for the list. I will look at ways to make #2 and #3 happen (#3 should be quick as well as #1). I am not sure how much time I will have left until end of this year so please be patient :)

@Martyx00
Copy link
Contributor

Martyx00 commented Nov 4, 2022

Having second thoughts on no.3, this will prevent marking items that are called from piece of code that is not marked as function. This would be undesirable behavior when reversing bare metal firmware (which we do a lot) as it often happens that all functions are not marked as functions even though they are.

@Martyx00
Copy link
Contributor

Martyx00 commented Nov 4, 2022

I have addressed no. 1 and no. 3 in the dev branch. Please use that for your PR with no.4 and no.5. There is still need for some fine tuning and adjsutments, I will merge to main once verything is ready.
https://github.com/Accenture/VulFi/tree/v2_dev

@VoidSec
Copy link
Contributor Author

VoidSec commented Nov 4, 2022

Having second thoughts on no.3, this will prevent marking items that are called from piece of code that is not marked as function. This would be undesirable behavior when reversing bare metal firmware (which we do a lot) as it often happens that all functions are not marked as functions even though they are.

You're right it's better to have this type of information rather than completely losing it. Worst case scenario one can "hide" this case from the results after exporting them.

@VoidSec
Copy link
Contributor Author

VoidSec commented Nov 14, 2022

This (#9) fix the "Missing Rules: _stdio_common_vsprintf" task

@VoidSec
Copy link
Contributor Author

VoidSec commented Nov 14, 2022

For the Windows API/Windows-related vulnerabilities I'll need a bit more time as I'm quite busy atm

@Martyx00
Copy link
Contributor

I will merger the branches to propagate changes so that those can be included in the new IDA plugin manager. Addition for the Win API calls will be included separately.

@VoidSec
Copy link
Contributor Author

VoidSec commented Jan 12, 2023

Sure, go ahead :D. I'm sorry but I didn't had the time to add that yet :(

@zhefox
Copy link
Contributor

zhefox commented Nov 9, 2023

I'm looking forward to your idea of ​​Add "dangerous" Windows API/Windows-related vulnerabilities. At the same time, I want to know what progress it has currently. I think we can start with the high-risk functions of the Windwos api and some high-risk functions of the kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants