Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 124 to 126 causes crash depending on Preferences #831

Open
Thulinma opened this issue Sep 22, 2024 · 3 comments
Open

Upgrade from 124 to 126 causes crash depending on Preferences #831

Thulinma opened this issue Sep 22, 2024 · 3 comments

Comments

@Thulinma
Copy link

System Details

  • OS: Arch
  • Thorium Version 126.0.6478.231

Problem
Upgrading from 124.X to 126.X causes a crash on boot if the Preferences file in the profile contains the string "theme":{"id":"","system_theme":1}, inside the extensions object. I'm guessing this is the setting that controls the experimental Thorium theme, which I had enabled in 124. Removing the string from the Preferences file causes the upgrade to succeed without further problems.

Additional Notes
Mostly putting this here so it can hopefully be automatically fixed in future releases, or at least so that others running into the same problem can find it and know how to solve it without needing to debug for a few hours like I ended up doing. 🙃

@Alex313031
Copy link
Owner

@Thulinma This is not the reason for the crash, but you're close. Thanks for letting me know, as I was wondering if the code change would cause crashes on other systems.

Also, what experimental thorium theme in M124 are you talking about.

@Thulinma
Copy link
Author

Ah yes, it was just a guess. Glad that you know what it is, at least! 👍

I.... don't recall what exact release had this, but some releases ago there was a theme of some sort mentioned in the "Thorium Experiments". I only noticed it was gone in the latest version but that may have actually disappeared much longer ago. I don't check the experiments list all that often. Sorry for any confusion! 😅

@Alex313031
Copy link
Owner

@Thulinma I think I fixed this here > 5b41ddb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants