Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regridder module #4

Closed
5 of 11 tasks
juliasloan25 opened this issue Sep 8, 2023 · 0 comments · Fixed by #19
Closed
5 of 11 tasks

Regridder module #4

juliasloan25 opened this issue Sep 8, 2023 · 0 comments · Fixed by #19
Assignees
Labels
new module 🚨 Implementation of a new module

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Sep 8, 2023

Create a module for regridding files between spaces.

ClimaCoupler.jl Regridder module: https://github.com/CliMA/ClimaCoupler.jl/blob/main/src/Regridder.jl
ClimaLSM.jl Regridder module: https://github.com/CliMA/ClimaLSM.jl/blob/main/src/shared_utilities/Regridder.jl

ClimaCoupler.jl Regridder tests: https://github.com/CliMA/ClimaCoupler.jl/blob/main/test/regridder_tests.jl
ClimaLSM.jl Regridder tests: https://github.com/CliMA/ClimaLSM.jl/blob/main/test/shared_utilities/regridder.jl

Note - DataCleanup

Maybe data cleanup functions should be moved to a separate module (e.g. DataCleanup)

  • nans_to_zero
  • missings_to_zero
  • clean_data
  • to_datetime (in TimeManager)

Closed by #8
Tracked by #39

To Do

  • Create table of all functions and structs with:
    • currrent repo locations
    • destination (ClimaUtilities or other)
    • test status
    • list of changes between repos, and other notes
  • Copy over functions that are shared between repos and unchanged (case 1)
  • Add tests for these functions
  • Copy functions that exist in only one repo (case 2)
  • Add tests for these functions
  • Copy over functions that exist in multiple repos and are changed between them (case 3)
  • Generalize function interfaces, extend functionality for all users
  • Add tests for these functions, update to use new interfaces
  • Test from user packages
  • Add compat entries in project for new deps
  • Add docs page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module 🚨 Implementation of a new module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant