Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGResult that saves info #236

Open
mohamed82008 opened this issue Jan 15, 2019 · 2 comments · May be fixed by #238
Open

CGResult that saves info #236

mohamed82008 opened this issue Jan 15, 2019 · 2 comments · May be fixed by #238

Comments

@mohamed82008
Copy link
Member

It would be nice to have a CGResult struct that saves things like the last residual, number of iterations needed to converge, and options. If this is approved in principle, I can make a PR. This will be a breaking change however. A similar thing may also need to be done for the other algorithms but I am mostly interested in CG now.
@haampie
Copy link
Member

haampie commented Jan 15, 2019

Yes, since forever cg(..., log = true) has been type unstable as well. See #185

@mohamed82008
Copy link
Member Author

Cool, will make a PR then.

@mohamed82008 mohamed82008 linked a pull request Jan 15, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return CGResult from cg and allow absolute tol mohamed82008/IterativeSolvers.jl
2 participants
@haampie @mohamed82008