New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new lattice design #24

Open

Roger-luo opened this issue Aug 27, 2020 · 1 comment

Collaborator

Roger-luo commented Aug 27, 2020

I'd like to move discussions around the new lattice design here. So we have something to keep track of.

Collaborator Author

Roger-luo commented Sep 2, 2020 •

edited

Loading

I think there are some issues with letting AbstractLattice being subtype of AbstractGraph:

Lattices are not graph exactly, given edges are not well-defined for lattices, on the same lattice, we can have edges, hyper-edges, etc. it's hard to tell what to return for LightGraphs.edges interface
Lattices can be converted to graphs only when the bonds etc. are defined, a pure geometric lattice doesn't contain this information

I think as a result we should prefer bonds instead of edges as our interface name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment