Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isin functions should return boolean mem fields rather than ndarrays #274

Open
atbenmurray opened this issue Mar 22, 2022 · 0 comments
Open

isin functions should return boolean mem fields rather than ndarrays #274

atbenmurray opened this issue Mar 22, 2022 · 0 comments
Assignees
@Liyuan-Chen-1024

Comments

@atbenmurray
Copy link
Member

atbenmurray commented Mar 22, 2022 •
edited
Loading

some of the isin functions return ndarray functions directly, but should return boolean NumericMemFields. You can see examples of this in FieldDataOps._unary_op where ndarrays are assigned to newly created NumericMemFields. Please add this to FieldDataOps.apply_isin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Liyuan-Chen-1024 Liyuan-Chen-1024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atbenmurray @Liyuan-Chen-1024