Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some edited images on macOS 15 do not show up as edited in OSXPhotos #1687

Open
RhetTbull opened this issue Sep 18, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@RhetTbull
Copy link
Owner

On macOS 15, ZASSET.ZHASADJUSTMENTS can have a value of other than 0 (no adjustment) or 1 (has adjustments). Specifically, a user reported an edited image with value of 2. This causes the check for PhotoInfo.hasadjustments to fail:

    @property
    def hasadjustments(self) -> bool:
        """True if picture has adjustments / edits"""
        return self._info["hasAdjustments"] == 1

The test should test for 0 or non-zero, not 1. Additionally, need to do some testing to see what the other value(s) mean and if that is something OSXPhotos should expose.

@RhetTbull RhetTbull added the bug Something isn't working label Sep 18, 2024
RhetTbull added a commit that referenced this issue Sep 19, 2024
RhetTbull added a commit that referenced this issue Sep 19, 2024
* Fix for #1687

* Temp fix for #1680, Catalina support

* Fix for #1670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant