Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9 to v1.10 upgrade instructions does not mention container name change #1262

Open
hawksight opened this issue Jul 19, 2023 · 4 comments
Open
Assignees
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@hawksight
Copy link
Member

The documentation for 1.10 release notes does mention this here

But if you just look at the relevant upgrade instructions, this change is not specifically called out, This could for example lead to a situation where a user has two containers in the pods where it crashloops as the newer containers cannot come up due to port conflicts:

$ k get pods -n cert-manager                                                                                                                                                                                    

NAME                                       READY   STATUS             RESTARTS        AGE
cert-manager-559f7bbfcd-9zrqg              1/2     CrashLoopBackOff   108 (32s ago)   8h
cert-manager-cainjector-6d46445566-65gh5   2/2     Running            0               8h
cert-manager-webhook-564c94659d-7fsmx      1/2     CrashLoopBackOff   108 (39s ago)   8h

We call out the OpenShift issue, so I think we should also call out this issue as it should be common enough due to helm's popularity.

@hawksight
Copy link
Member Author

/assign

I'll try to address this

@inteon
Copy link
Member

inteon commented Feb 12, 2024

@hawksight have you had time to work on this?

@hawksight
Copy link
Member Author

Not yet, but thanks for the reminder. Might not get to it this week.

@SgtCoDFish SgtCoDFish added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jul 16, 2024
@SgtCoDFish
Copy link
Member

I've set this as backlog priority since this is for quite old versions of cert-manager now, but it might still be nice to document. Alternatively, if we wanted to just close this that'd be fine too. Your call @hawksight !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants