Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VarCat Data Dump and Submission through the ClinVar submission API #5

Open
wesleygoar opened this issue Apr 30, 2024 · 8 comments · May be fixed by #9
Open

VarCat Data Dump and Submission through the ClinVar submission API #5

wesleygoar opened this issue Apr 30, 2024 · 8 comments · May be fixed by #9
Assignees
Labels
requirement A requirement for the project

Comments

@wesleygoar
Copy link
Collaborator

@korikuzma we need to get a dump of the VarCat curation data that I have been working on to then test the ClinVar Submission tool. This will allow me to check the data on the test server and see what feedback, if any, we need to provide to ClinVar.

@wesleygoar wesleygoar added the requirement A requirement for the project label Apr 30, 2024
@korikuzma
Copy link
Collaborator

@wesleygoar I will only focus on the assertions that are "Awaiting Review" (n=21)

@korikuzma
Copy link
Collaborator

@wesleygoar How did you want the onco evidence code data to be structured in the comment? See this comment on how the VCI team structures this.

@korikuzma
Copy link
Collaborator

@wesleygoar How did you want the onco evidence code data to be structured in the comment? See this comment on how the VCI team structures this.

comment = f"{significance_statement} The total score for this classification is {score} and the evidence supporting this classification are as follows. {statement} (ClinGen/CGC/VICC 2022: {evidence_code})"

Is what we will use

@korikuzma
Copy link
Collaborator

@wesleygoar Did you want to include localID and localKey as described here. If so, did you want to structure it as localID = varcat.variant:{id} and localKey = varcat.overall_assessment:{id} or something else?

@wesleygoar
Copy link
Collaborator Author

@wesleygoar Did you want to include localID and localKey as described here. If so, did you want to structure it as localID = varcat.variant:{id} and localKey = varcat.overall_assessment:{id} or something else?

@korikuzma this sounds good to me.

@korikuzma
Copy link
Collaborator

@wesleygoar How did you want the onco evidence code data to be structured in the comment? See this comment on how the VCI team structures this.

comment = f"{significance_statement} The total score for this classification is {score} and the evidence supporting this classification are as follows. {statement} (ClinGen/CGC/VICC 2022: {evidence_code})"

Is what we will use

I'm realizing this doesn't make sense for places where a user manually overrides the classification. For example, in 22-29642211-C-T/Schwannoma we'd have the following statement: "This variant is classified oncogenic in Schwannoma. The total score for this classification is 3".

Without being able to see the assessment, I was confused on why it was classified as oncogenic but only had a score of 3. It wasn't until I saw the following information that stated you manually changed the classification score:

  "description": "This is a null variant in a TSG. The score should be 11 which is an oncogenic classification. ",
  "rationale_description": "OncoKB cancer genes modal is broken but this should have a classification of oncogenic. ",

@wesleygoar how should we capture this information in the comment? It is not always guaranteed that a user will provide text like you where it is clear that the classification was manually changed.

@korikuzma korikuzma linked a pull request May 9, 2024 that will close this issue
@korikuzma korikuzma linked a pull request May 9, 2024 that will close this issue
@wesleygoar
Copy link
Collaborator Author

@korikuzma yeah, I really don't like this either. We should update VarCat to give the users the ability to manually add and override the computed score.

@wesleygoar
Copy link
Collaborator Author

@korikuzma although, thinking about this more, once the manual onco evidence PR is in, there really shouldn't be a reason that someone will need to manually override the overall oncogenicity. For now, we should avoid submitting these data that I had to perform manual override on the overall classification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requirement A requirement for the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants