Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode does not persist between same page #130

Open
3 tasks done
gbowne1 opened this issue Oct 18, 2022 · 2 comments
Open
3 tasks done

Dark Mode does not persist between same page #130

gbowne1 opened this issue Oct 18, 2022 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Oct 18, 2022

Prerequisites

Current Behavior

Dark mode / theme does not persist once toggled on.

Noticed this when on Contact page (contact.html). Clicked on the Contact item in the NavBar. Theme changed back to Light from Dark without having to toggle.

I assume you can persist the theme state. This might require a theme.js controller.

Expected Behavior

Persistent Dark mode or Light mode till user turns the feature on or off and changing pages does not change theme mode.

Theme should not change between pages, in other words, the mode should not turn off till the user toggles the theme switch.

Steps to Reproduce

  • Navigate to /contact.html
  • Click on the dark mode toggle to toggle Dark theme.
  • Click on the Contact in the NavBar.

Notice that now the dark mode turns off.

@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Oct 18, 2022
@gbowne1 gbowne1 added this to the Website Frontend milestone Oct 18, 2022
@Halim-Shams
Copy link

Hey, can give me some more info like, which frontend framework you are using? if you are using ReactJS I can help you with that.

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 18, 2022

@Halim-Shams

This does not use a framework of any kind.

@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested and removed bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jan 2, 2023
@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request and removed bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Feb 3, 2023
@gbowne1 gbowne1 added help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
Development

No branches or pull requests

2 participants