Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Nova 3 supported..? #66

Open
Jaspur opened this issue May 15, 2020 · 11 comments
Open

Is Nova 3 supported..? #66

Jaspur opened this issue May 15, 2020 · 11 comments

Comments

@Jaspur
Copy link

Jaspur commented May 15, 2020

Hi,
Is Nova V3 supported?
Because this the result of a simple
Currency::make(__('Costs'), 'price')->currency('EUR'),
FkhjZ9xk

Expectation is that the string is correctly translated and the currency is in € and not $.

Added it as simple as:
HasMany::make(__('Product type'), 'productTypes', ProductType::class)->inline()

When I remove the ->inline(), it works like expected.

@dvanscott @adammparker @brandonferens @bryanjamesmiller @dvanscott @jrseliga @luisdalmolin @michaelfox @navneetrai

@ondroftw
Copy link

same here

@annejan89
Copy link

same here!

@Jessetje30
Copy link

Is here any work around for?

@Jaspur
Copy link
Author

Jaspur commented May 27, 2020

@kirschbaum replied by email:

Thanks for reaching out! We’re really busy at the moment, but are really looking forward to getting back to work on this project. Ok not yet sure when we will get back to it though.

@ragingdave
Copy link

This doesn't seem to be just Nova 3. I'm running Nova 2, and experiencing the same issue.

@ragingdave
Copy link

ragingdave commented Jun 10, 2020

Update: seems to just need a new release as outlined here: #42
@kirschbaum can you set up a new release since that at least anecdotaly resolves this and 42?

@lennardv2
Copy link

I have the same troubles here, when can you release an update?

@davide-casiraghi
Copy link

same problem here..

@jeurrutia
Copy link

Same problem

@GerhardKotze
Copy link

GerhardKotze commented Apr 22, 2021

same problem, but otherwise love your package!

@ahinkle
Copy link

ahinkle commented Jun 5, 2021

A bit unfortunate that this wonderful package might be abandoned with it being over a year with no updates from the maintainers. Was anyone able to fork a solution? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants