Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragments / Colocate data requirements #89

Open
jfrolich opened this issue Sep 26, 2019 · 0 comments
Open

Fragments / Colocate data requirements #89

jfrolich opened this issue Sep 26, 2019 · 0 comments

Comments

@jfrolich
Copy link

I am using graphql_ppx in a project and it is amazing. Really great work!

One issue I am trying to tackle is that with React it is very convenient to colocate the data requirements with the components. I have a few issues with fragments currently:

  • If you only use variables in fragments the query won't compile saying that a variable is not used
  • A bug that the bsField directive is not removed from the query (is there a way to not need that field) Fix @bsField being printed in output #76 (PR fixing this)
  • Reduced type checking of fragments (couldn't explore how much the type checking is reduced due to previous bug)

How did other users tackle this. And is there a way to update this ppx to have first class fragment support.

I am a new user to OCaml/ReasonML, and browsed through this codebase and it's pretty extensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant