Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ClusterLabels #269

Open
aii-nozomu-oki opened this issue Sep 7, 2023 · 6 comments
Open

Support ClusterLabels #269

aii-nozomu-oki opened this issue Sep 7, 2023 · 6 comments
Labels
enhancement New feature or request Stale

Comments

@aii-nozomu-oki
Copy link
Contributor

Describe the enhancement
I would like to manage ManagedCluster using labels.
Currently, this is possible through, for example, kubectl label, but it would be useful to accomplish this through an OCM ecosystem such as clusteradm.

Related issues/pull requests:
open-cluster-management-io/registration#225
open-cluster-management-io/api#252
#234

@aii-nozomu-oki aii-nozomu-oki added the enhancement New feature or request label Sep 7, 2023
@qiujian16
Copy link
Member

Do you intend to allow setting the label of the cluster when the first bootstrap?

@aii-nozomu-oki
Copy link
Contributor Author

Yes, what I finally want is clusteradm join --cluster-labels=[key=value].
To accomplish just that, maybe support at the API level is not needed.

@qiujian16
Copy link
Member

cc @xuezhaojun

Copy link

This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

@github-actions github-actions bot added the Stale label Jan 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
@xuezhaojun xuezhaojun removed the Stale label Jan 24, 2024
@xuezhaojun xuezhaojun reopened this Jan 24, 2024
Copy link

This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

@github-actions github-actions bot added the Stale label May 24, 2024
@qiujian16 qiujian16 removed the Stale label May 27, 2024
Copy link

This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

@github-actions github-actions bot added the Stale label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants