developing formulae: fsarchive

[phreed]

Output of brew config

HOMEBREW_VERSION: 4.4.0-9-g7841c53
ORIGIN: https://github.com/Homebrew/brew
HEAD: 7841c5306269976c1f472bccd4d5e05295582510
Last commit: 2 hours ago
Core tap HEAD: 70d2ce454d084b5327ac5dce47b5b89b47976f46
Core tap last commit: 23 minutes ago
Core tap JSON: 01 Oct 17:00 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :0
HOMEBREW_EDITOR: /usr/bin/nano
HOMEBREW_MAKE_JOBS: 22
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_SORBET_RUNTIME: set
SUDO_ASKPASS: /usr/libexec/openssh/gnome-ssh-askpass
Homebrew Ruby: 3.3.5 => /var/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.5/bin/ruby
CPU: 22-core 64-bit unknown_0x6_0xaa
Clang: 17.0.6
Git: 2.46.1 => /bin/git
Curl: 8.2.1 => /bin/curl
Kernel: Linux 6.10.7-100.fc39.x86_64 x86_64 GNU/Linux
OS: Bluefin-dx 39 (FROM Fedora Silverblue) (Archaeopteryx)
Host glibc: 2.38
/usr/bin/gcc: 13.3.1
/usr/bin/ruby: N/A
glibc: N/A
gcc@11: N/A
gcc: N/A
xorg: N/A

Output of brew doctor

Warning: You have uncommitted modifications to Homebrew/homebrew-core.
If this is a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
  cd /var/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core && git stash -u && git clean -d -f

Uncommitted files:
  ?? Formula/f/fsarchiver.rb

Description of issue

I am working on a formulae for fsarchiver.
I am getting a compilation error.
uuid.h: No such file or directory
But the uuid.h file is present: /home/linuxbrew/.linuxbrew/Cellar/util-linux/2.40.2/include/uuid/uuid.h
I suspect the problem stems from the include being #include <uuid.h> and it should be #include <uuid/uuid.h>.
What is the proper way to adjust the fsarchiver.rb?
I have been looking at https://github.com/Homebrew/homebrew-core/blob/685b78c42e92a8ea57904250c483beea9ca1a7ec/Formula/e/e2fsprogs.rb as my model.

class Fsarchiver < Formula
  desc "file system archiver for linux"
  homepage "http://www.fsarchiver.org"
  url "https://github.com/fdupoux/fsarchiver/releases/download/0.8.7/fsarchiver-0.8.7.tar.gz"
  sha256 "f7cd059e70fc57e888db282c622ec050c0dcdbaacc65e3c1eb163cd9d92d810d"
  license "GPL-2.0"

  head do
    depends_on "autoconf" => :build
    depends_on "automake" => :build
    depends_on "libtool" => :build
  end

  depends_on "pkg-config" => :build

  depends_on "zlib"
  depends_on "lzo"
  depends_on "lz4"
  depends_on "bzip2"
  depends_on "libgcrypt"
  depends_on "e2fsprogs"
  depends_on "xz"
  depends_on "zstd"

  on_macos do
    depends_on "gettext"
  end

  on_linux do
    depends_on "util-linux"
  end

  def install
    std_config_args = [
      "--prefix=#{prefix}",
      "--sysconfdir=#{etc}",
      "--disable-e2initrd-helper",
      "MKDIR_P=mkdir -p",
    ]
    std_config_args += if OS.linux?
      %w[
        --enable-elf-shlibs
        --disable-fsck
        --disable-uuidd
        --disable-libuuid
        --disable-libblkid
        --without-crond-dir
      ]
    else
      ["--enable-bsd-shlibs"]
    end

    system "./configure", "--prefix=/usr", *std_configure_args

    system "make"
    system "make install"
  end

  test do
    system "false"
  end
end

fsarchiver.rb.txt

• https://www.fsarchiver.org/installation/

note: This is my first formulae.

[p-linnane]

This is because you're not actually passing --disable-libuuid. You're trying to add these flags to std_config_args, but that never gets used anywhere.

[phreed]

system "./configure", "--prefix=/usr", *std_configure_args

I presumed it would be used in the configure.

[gromgit]

system "./configure", "--prefix=/usr", *std_configure_args

I presumed it would be used in the configure.

Not when you're setting a different variable called std_config_args.

[phreed]

When I run

brew install --build-from-source fsarchiver --debug

I get the error,

BuildError: Failed executing: make
1. raise
2. ignore
3. backtrace
4. irb
5. shell
Choose an action:

I choose shell and do the following:

cd src
make -d fsarchiver-fs_ext2.o

This reproduces the error.

Makefile:795: update target 'fsarchiver-fs_ext2.o' due to: target does not exist
echo "  CC      " fsarchiver-fs_ext2.o;gcc -DHAVE_CONFIG_H -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I. -I..    -g -O2 -Wall -std=gnu99 -rdynamic -ggdb -I/home/linuxbrew/.linuxbrew/Cellar/xz/5.6.2/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/ext2fs -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/et -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/et -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/e2p -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/util-linux/2.40.2/include/blkid -I/home/linuxbrew/.linuxbrew/Cellar/util-linux/2.40.2/include/uuid -g -O2 -c -o fsarchiver-fs_ext2.o `test -f 'fs_ext2.c' || echo './'`fs_ext2.c
Putting child 0x56030a182a10 (fsarchiver-fs_ext2.o) PID 213582 on the chain.
Recipe of 'fsarchiver-fs_ext2.o' is being run.
Live child 0x56030a182a10 (fsarchiver-fs_ext2.o) PID 213582 
  CC       fsarchiver-fs_ext2.o
fs_ext2.c:23:10: fatal error: ext2fs.h: No such file or directory
   23 | #include <ext2fs.h>
      |          ^~~~~~~~~~
compilation terminated.

However if I run the compile by hand.

gcc -DHAVE_CONFIG_H -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I. -I..    -g -O2 -Wall -std=gnu99 -rdynamic -ggdb -I/home/linuxbrew/.linuxbrew/Cellar/xz/5.6.2/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/ext2fs -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/et -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/et -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include/e2p -I/home/linuxbrew/.linuxbrew/Cellar/e2fsprogs/1.47.1/include -I/home/linuxbrew/.linuxbrew/Cellar/util-linux/2.40.2/include/blkid -I/home/linuxbrew/.linuxbrew/Cellar/util-linux/2.40.2/include/uuid -g -O2 -c -o fsarchiver-fs_ext2.o `test -f 'fs_ext2.c' || echo './'`fs_ext2.c

It compiles and produces the object file (with warnings).

fs_ext2.c: In function ‘extfs_getinfo’:
fs_ext2.c:454:52: warning: argument to ‘sizeof’ in ‘strncpy’ call is the same expression as the source; did you mean to use the size of the destination? [-Wsizeof-pointer-memaccess]
  454 |         strncpy(label, super->s_volume_name, sizeof(super->s_volume_name));
      |                                                    ^
fs_ext2.c: In function ‘extfs_mkfs’:
fs_ext2.c:226:39: warning: ‘%s’ directive output may be truncated writing up to 2047 bytes into a region of size 64 [-Wformat-truncation=]
  226 |         snprintf(uuid, sizeof(uuid), "%s", buffer);
      |                                       ^~   ~~~~~~
fs_ext2.c:226:9: note: ‘snprintf’ output between 1 and 2048 bytes into a destination of size 64
  226 |         snprintf(uuid, sizeof(uuid), "%s", buffer);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

How does running the compile from the makefile produce a different result?

[phreed]

I though it might have something to do with the HOMEBREW_CCCFG environment variable.

Now I think it may be that a defective copy of make might be running.
When I select (5) the shell, cd src.
The following version of make, appears to build everything properly.

/home/linuxbrew/.linuxbrew/opt/make/bin/make all

This version is installed by brew install make.

The following make which is the one found in the PATH during the build, produces the include errors mentioned above.

/var/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/linux/super/make

When I ask for the version information the two report the same information.