Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 chatbot - Chatbot is showing two scrollbars #119

Closed
divyanshiGupta opened this issue Sep 10, 2024 · 5 comments · Fixed by #173
Closed

v6 chatbot - Chatbot is showing two scrollbars #119

divyanshiGupta opened this issue Sep 10, 2024 · 5 comments · Fixed by #173
Assignees
Labels
bug Something isn't working v6.x Applies to only the PF6 version
Milestone

Comments

@divyanshiGupta
Copy link

Chatbot should have only one scrollbar, preferably on the MessageBox component.

Screen.Recording.2024-09-10.at.6.20.39.PM.mov
@nicolethoen nicolethoen self-assigned this Sep 10, 2024
@rebeccaalpert rebeccaalpert added this to the 2024.Q3 milestone Sep 10, 2024
@rebeccaalpert rebeccaalpert added v6.x Applies to only the PF6 version bug Something isn't working labels Sep 11, 2024
@asuwebdesign
Copy link
Collaborator

Ansible team has also replicated this issue. They're seeing it in Linux/Chrome.

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Sep 20, 2024

@asuwebdesign pointed me to the Ansible team's repo. I was able to pull it down and run it, and saw the double scrollbar issue. They also had buttons, etc. that were not the right shape. I adjusted their imports so these were the very last set of imports in their index.tsx file and the second scrollbar went away:

import '@patternfly/react-core/dist/styles/base.css';
import '@patternfly/patternfly/patternfly-addons.css';

// Add your extension CSS below
import '@patternfly/virtual-assistant/dist/css/main.css';

I'll try to meet with @divyanshiGupta or Rohit next week and see if their issue is the same or has a different cause.

@rebeccaalpert
Copy link
Member

I met with Rohit and @divyanshiGupta this morning and they have a different issue. Divyanshi reports that the extra scrollbar is on .pf-chatbot__content. I'm meeting with Karthik on Thursday to see if I can run Developer Hub Lightspeed locally to debug this on their side.

@rebeccaalpert rebeccaalpert linked a pull request Sep 26, 2024 that will close this issue
@rebeccaalpert rebeccaalpert modified the milestones: 2024.Q3, 2024.Q4 Sep 26, 2024
@rebeccaalpert
Copy link
Member

rebeccaalpert commented Sep 26, 2024

@divyanshiGupta - I think this should be fixed on 2.0.0-alpha.37. I pulled this into Lightspeed locally and it looks better to me (some other things look weird though - so I would appreciate it if you guys could let us know if this doesn't work on your side):

Screen.Recording.2024-09-26.at.1.02.23.PM.mov

Thanks for onboarding me!

The release is available on:

GitHub release
npm package (@alpha dist-tag)

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Sep 27, 2024

I think this is ultimately being caused by #175. Going to close this for now since the immediate issue is resolved, but I think CSS problems will continue to get worse for RHDH as this gets more complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v6.x Applies to only the PF6 version
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants