Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Ripser.py and Cechmate interfaces #7

Open
sauln opened this issue Apr 17, 2019 · 0 comments
Open

Unify Ripser.py and Cechmate interfaces #7

sauln opened this issue Apr 17, 2019 · 0 comments

Comments

@sauln
Copy link
Member

sauln commented Apr 17, 2019

As an extension of #6, we should also update the interfaces to abide by fit_transform

Currently, the Ripser.py Rips object uses fit_transform to construct the diagrams. Cechmate uses build to construct the filtration and diagrams to build the diagrams.

We should convert cechmate so that fit builds the simplices and transform constructs the diagrams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sauln