Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no-op pops. #3530

Open
wants to merge 1 commit into
base: version/0-47-0-RC1
Choose a base branch
from
Open

Remove no-op pops. #3530

wants to merge 1 commit into from

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 4, 2024 •
edited by github-actions bot
Loading

BugDX-3087 Buildexpression unmarshalling has potential pathing issues

We still want to keep context, but popping is not necessary since mutations are done locally (path = append(path, ...)), and do not affect the values passed by callers.

@mitchell-as mitchell-as marked this pull request as ready for review October 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos Awaiting requested review from MDrakos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
test: buildscripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mitchell-as