Update channel names and thumbnails when refreshing subscriptions #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
I tried both RSS & IV API No thumbnail refreshed, expected? Using Local API does refresh the thumbnails |
|
Yes, that is expected:
|
PikachuEXE
approved these changes
Feb 19, 2024
ChunkyProgrammer
approved these changes
Feb 23, 2024
ChunkyProgrammer
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
|
@ChunkyProgrammer thats about the thumbnails. Im talking about the channel name |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 7, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update channel names and thumbnails when refreshing subscriptions
Pull Request Type
Related issue
Will help with #4340
Description
This pull request is based on a similar philosophy as #4667 (we are already making the API request, so we might as well use the data), however this pull request will have a more noticable benefit for users. #4340 removes the API requests to fetch the thumbnail URLs during the subscriptions import to avoid making extra API requests, so this pull request uses the thumbnail URLs that we get in API requests that we are already making.
Unfortunately not all requests that we make on the subscriptions page contain channel thumbnail URLs, in the cases that they are missing, we only update the channel name.
Here is the list of requests that have both the channel thumbnails and channel names:
All other requests e.g. RSS feeds and videos + live Invidious API requests don't return thumbnail URLs.
Testing
Try refreshing the various subscription tabs on both API backend with RSS disabled and enabled.
Here is a profiles database that has no thumbnail URLs and has all channel names set to
aaa, this will allow you to test that the data actually gets updated (You can see it happen live in the side bar if you expand it). It contains 3 of YouTube's own channels the@YouTube,@YouTubeMusicand@YouTubeOriginalschannels.profiles.txt
Download the file, change the file extension from '.txt' to
.dband import through FreeTube's UI or replace it in the filesystem.Desktop