-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Playlist Sort By Video Duration #5627
base: development
Are you sure you want to change the base?
Conversation
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Odd. Now it is not displaying the toast message at all |
Head branch was pushed to by a user without write access
Alright that should fix the issue. |
Head branch was pushed to by a user without write access
Works fine so far except I think the notice should be shown also when changing sort order in single playlist view (unless already shown
(B)
|
Head branch was pushed to by a user without write access
7143e62 moves the call to when the playlist items are sorted, so if you load a playlist and then change the sorting, it'll still show. This means (A) and most of (B) are handled. I'm not terribly sure how to make it only fire once though. Thoughts? |
Head branch was pushed to by a user without write access
Alright, I've given single-firing only a shot, and also tweaked the time to be only 5 seconds, as 10 seemed a little long to me |
As that's what I've got working now, that's all good with me. One thing I would suggest, is maybe a button that reloads the metadata for all videos in a playlist? That way you don't care how long it takes, as it's an action invoked by the user themselves. |
@Hoverth That might be misleading for the user as they might be expecting it to fetch everything from YouTube, when it would actually be updating based on the watch history. Fetching loads of data unnecessarily from YouTube is the last thing we would want to do. |
Weird idea and not sure if feasible but what about using the toast message for this purpose. Message would need to be slightly modified but if we add something like this to the toast |
@absidue That's fair enough. Is there any other issues with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only method with side effects should be named after the action
Co-authored-by: PikachuEXE <git@pikachuexe.net>
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just loop it once?
Test locally before committing that change~
Co-authored-by: PikachuEXE <git@pikachuexe.net>
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
It does feel a little bit faster, but that could just be placebo. Either way, it should be more efficient now. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Add Playlist Sort By Video Duration
Pull Request Type
Related issue
Closes: #5268
Description
Closes issue #5268 and PR #5423. It works off what @creotove put in their PR, but also includes a small notification if there is a video in the playlist that does not have a time attached to it.