Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ft-list-video.scss #5658

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

An-anonymous-coder
Copy link

@An-anonymous-coder An-anonymous-coder commented Sep 6, 2024

Fixed DeArrow thumbnails for Shorts

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #5568

Description

The fix removes the preloaded 16 by 9 aspect ratio for thumbnails so that YouTube Shorts DeArrow thumbnails display in their intended aspect ratios.

Additional context

I have not tested it, because I don't know how.

This is a fix for FreeTubeApp#5568 which simply removes the default aspect ratio in favor of the original.
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 6, 2024 17:48
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 6, 2024
@absidue
Copy link
Member

absidue commented Sep 8, 2024

If you read the line you are editing it says 16/9 auto that means that it uses the 16:9 aspect ratio until the image is loaded (prevents the UI from jumping all over the place) and after that it uses the aspect ratio of the image, so this won't fix the problem that you are facing.

https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio#fallback_to_natural_aspect_ratio

@absidue absidue added U: Waiting for Response from Author and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 8, 2024
@An-anonymous-coder
Copy link
Author

If you read the line you are editing it says 16/9 auto that means that it uses the 16:9 aspect ratio until the image is loaded (prevents the UI from jumping all over the place) and after that it uses the aspect ratio of the image, so this won't fix the problem that you are facing.

https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio#fallback_to_natural_aspect_ratio

Alright, then I am unaware of what is causing the issue. The images in the network tab are in the correct aspect ratio, but after looking for a while this is the only place I was able to find that references a 16 by 9 aspect ratio while loading.

@An-anonymous-coder
Copy link
Author

If you read the line you are editing it says 16/9 auto that means that it uses the 16:9 aspect ratio until the image is loaded (prevents the UI from jumping all over the place) and after that it uses the aspect ratio of the image, so this won't fix the problem that you are facing.

https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio#fallback_to_natural_aspect_ratio

Is it possible that the issue is caused by the original 16x9 thumbnails being loaded first, and then the DeArrow thumbnails? It means that the first thumbnails might hard set the aspect ratio before the other thumbnails are loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DeArrow thumbnails for Shorts disproportionately stretched
2 participants