-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert X64 AppImage to static runtime #5747
base: development
Are you sure you want to change the base?
Conversation
Drops libfuse2 dependency from AppImage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use the filename everywhere, as you currently have a mix of using the filename in some places and wild cards in others. Additionally it probably makes sense to assign the filename to a variable after the cd build
command and reference that variable.
I haven't tested the generated AppImage yet (need to boot up my Ubuntu VM and figure out how to run and then afterwards remove AppImages).
I'm okay with doing this after build hack for the moment but in the long run it would be much better if electron-builder handled that for us, that way people would be able to reproduce the builds easier on their own machines without having to do these steps manually after the build. As for the why it does't work for the arm AppImage, that's because the GitHub runners are x64, so it would probably be a lot better if electron-builder produced the AppImages with the static runtimes in the first place instead of having to do this patching after the fact.
Head branch was pushed to by a user without write access
Done, worth mentioning that using appimagetool gives the ability of creating the .zsync files that allow for delta updates in the AppImage with AppImageUpdate, which I will try to add after this PR. |
Convert X64 AppImage to static runtime
Pull Request Type
Related issue
Closes #5714 #5641 but not fully since I was only able to do this for the X64 build.
Description
This change drops libfuse2 dependency from the AppImage, which prevents them from working on newer distros that no longer ship libfuse2.
Testing
Artifact
Desktop
Additional context
I was not able to fix this on the arm builds because even though I tried using the same runners that the upload actions for those use, it complains that it can't execute the appimage to extract it, which is needed in order to convert it.