Upgrade eslint 8 > 9

[PikachuEXE]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Description

• Can't use --ext anymore, and using blob like ./**/*.js is very slow compared to specific folders, so only 2 folders are specified for js/vue files
• Separate config files for json/yaml files due to I can't avoid recommended config from being applied on them
• Draft until [New] support eslint 9 import-js/eslint-plugin-import#2996 released

Screenshots

Testing

• yarn run lint
• yarn run lint-json
• yarn run lint-yml

Desktop

• OS:
• OS Version:
• FreeTube version:

Additional context

[PikachuEXE]

Since we can switch from standard to neostandard later maybe we can just upgrade to ESLint 9 first?

[ChunkyProgrammer]

We should definitely try to fix: Separate config files for json/yaml files due to I can't avoid recommended config from being applied on them

Since IDEs/code editors wont be able to highlight the issues

[absidue]

Please import the list instead of hardcoding it, so that we don't have to maintain it in multiple places. Using import activeLocales from './static/locales/activeLocales.json' with { type: 'json' } and then calling .join(',') on the imported array should work.

According to the history drop down on https://nodejs.org/api/esm.html#import-attributes the with keyword is supported in Node 21+ and in the LTS versions 18.20+ and 20.10+, so we should be fine using it.

[PikachuEXE]

With dynamic import, got warning (probably non issue assuming it eventually no longer Experimental

const { default: activeLocales } =
  await import('./static/locales/activeLocales.json', { with: { type: 'json' } })

Also static import would only cause syntax error with node 20.17.0

[absidue]

The reason it didn't work with the static import is because of the missing : between type and 'json'.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[PikachuEXE]

@ChunkyProgrammer config files merged
Turns out localeDir needed in all config blocks (even for json/yaml

[absidue]

Windows CMD doesn't interpret single quotes, so it passes them through to eslint and then eslint fails to find files that start and end with single quotes. I've suggested changes to switch to double quotes instead.

[PikachuEXE]

Updated~