-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaner: rewrite pkg-config file Cellar paths and keg-only #18229
base: master
Are you sure you want to change the base?
Conversation
Library/Homebrew/cleaner.rb
Outdated
pc_files.each do |pc_file| | ||
any_modification = T.let(false, T::Boolean) | ||
lines = pc_file.each_line.map do |line| | ||
any_modification ||= line.gsub!(@formula.prefix.realpath.to_s, @formula.opt_prefix.to_s).present? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing is that this doesn't handle multiple copies of formula in Cellar. I guess the more accurate way would be to handle this during link/unlink but that makes logic a bit more complex than always using opt path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to not handle multiple formulae in Cellar.
Library/Homebrew/cleaner.rb
Outdated
keg_only_pc_files = @formula.deps | ||
.reject { |d| d.build? || d.test? } | ||
.map(&:to_formula) | ||
.select(&:keg_only?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps controversial idea: I think this could be usefully done for all formulae, not just keg-only. We've debated for a while about whether we should try to support formulae when brew unlink
ed and, generally, I think we should.
d7266a1
to
b45a7a2
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Would be nice to get this in in some form at some point. |
b45a7a2
to
8add1db
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Concept idea based on manual work in Homebrew/core, e.g.