-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump more files to Sorbet typed: strict
#18354
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @issyl0! A few style suggestions, none blocking.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com> Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Sorry for the delay here, I thought the style issues were the only ones. But I'll get around to fixing the actual typechecking failures hopefully tonight! |
@instruction_column_index ||= {} | ||
sig { params(file: T.any(Pathname, String), objdump: Pathname).returns(T::Boolean) } | ||
def cpuid_instruction?(file, objdump) | ||
@instruction_column_index ||= T.let({}, T.nilable(T::Hash[String, Integer])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@instruction_column_index ||= T.let({}, T.nilable(T::Hash[String, Integer])) | |
@instruction_column_index ||= T.let({}, T.nilable(T::Hash[Pathname, Integer])) |
Sorry, I may have left you a bad suggestion here previously 🙃
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?typed: strict
in all (non-package) files in Homebrew organisation #17297.