neovim: simplify install method
#192876
Open
neovim: simplify install method
#192876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need all these nested `cd`s by using CMake's `-S` and `-B` flags to point to the source and build directories respectively. Let's do that. We also currently iterate through all the resources twice -- once to stage them all, and then again to build all of them. Let's do that only once instead by staging and building in one pass. Finally, let's remove some unneeded dependencies. There doesn't appear to be any linkage to `libnsl`, and `unzip` was only needed when we were building luarocks. We're not building any luarocks anymore, so we don't need it.
github-actions
bot
added
the
lua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?We don't need all these nested
cds by using CMake's-Sand-Bflags to point to the source and build directories respectively. Let's
do that.
We also currently iterate through all the resources twice -- once to
stage them all, and then again to build all of them. Let's do that only
once instead by staging and building in one pass.
Finally, let's remove some unneeded dependencies. There doesn't appear
to be any linkage to
libnsl, andunzipwas only needed when we werebuilding luarocks. We're not building any luarocks anymore, so we don't
need it.