Add test that ensures that keys wrapped with a leased key can be decr… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypted after turning off leasing
ernieturner
commented
Jul 9, 2020
| return bytes.length > DOCUMENT_HEADER_META_LENGTH | ||
| && bytes[0] == CURRENT_DOCUMENT_HEADER_VERSION && containsIroncoreMagic(bytes) | ||
| && getHeaderSize(bytes) == 0; | ||
| && getHeaderSize(bytes) >= 0; |
There was a problem hiding this comment.
@skeet70 Just so you're aware, I had to change this because we haven't prioritized/worked on #15. With this change we can at least prevent errors if someone tried to decrypt a document that was encrypted with the Node SDK. We can discuss in grooming/planning how far we want to take that other ticket and if/when to release this change.
skeet70
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ypted after turning off leasing