Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with division by zero in complex simshow #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roflmaostc
Copy link
Member

Hi,

just a division by zero bug which causes hard errors inside Pluto:

# master
julia> simshow(zeros(ComplexF32,(2,2)))
2×2 Array{HSV{Float32},2} with eltype ColorTypes.HSV{Float32}:
 HSV{Float32}(0.0,1.0,NaN)  HSV{Float32}(0.0,1.0,NaN)
 HSV{Float32}(0.0,1.0,NaN)  HSV{Float32}(0.0,1.0,NaN)

# fix
julia> simshow(zeros(ComplexF32,(2,2)))
2×2 Array{HSV{Float32},2} with eltype ColorTypes.HSV{Float32}:
 HSV{Float32}(0.0,1.0,0.0)  HSV{Float32}(0.0,1.0,0.0)
 HSV{Float32}(0.0,1.0,0.0)  HSV{Float32}(0.0,1.0,0.0)

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (05ec585) to head (2718586).

❗ Current head 2718586 differs from pull request most recent head ea2d5fb. Consider uploading reports for the commit ea2d5fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   88.32%   88.41%   +0.09%     
==========================================
  Files           7        7              
  Lines         257      259       +2     
==========================================
+ Hits          227      229       +2     
  Misses         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roflmaostc
Copy link
Member Author

Maybe we change the CI to Julia 1.6? Seems like some compat issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant