Record resnorm in powm! #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction Remove solve function
Remove unused iterable constructors and add missing tests for initial guess for x
…zed-algorithms Move randomized algorithms from the package
…ly-convergence-history Make convergence history show a summary
…-to-struct Fix mutable structs that are not mutable
…-as-broadcast Use broadcasting rather than BLAS calls
Reduce allocation in IDRS inner loop
…-name Resolve conflicting name 'Hessenberg'
Allow pre-allocation and re-use of buffers in CG
as mentioned in the docstring
tkf
commented
Apr 8, 2018
| @@ -21,7 +21,7 @@ end | |||
|
|
|||
| @inline converged(p::PowerMethodIterable) = p.residual ≤ p.tol | |||
|
|
|||
| @inline start(p::PowerMethodIterable) = 0 | |||
| @inline start(p::PowerMethodIterable) = 1 | |||
There was a problem hiding this comment.
Alternatively, we can do reserve!(history, :resnorm, maxiter + 1) but iterating maxiter + 1 instead of maxiter was a minor bug so why not fix it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in the docstring.