28 sliding regions #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created reg_f3d_sli .h and .cpp files updated CMakeLists to build new class
tidied up GetDeformationField() and GetSimilarityMeasureGradient() methods
already implemented changed reg_base so that methods for allocating warped, def field, and warped gradent are called after calling method to initialise current level as this method assigns currentDistanceMap which is required to allocate the warped distance maps which are allocated in AllocateWarped method
modified reg_f3d (executable) to parse and set sliding regions options ready to test
…oth regions now done
made GetWarpedImage method work with sliding registration results code now saves a result, but it was 'blank', so still more bugs to find and fix!
…' and 'region2' to name of saved CPGs
… mask supplied corrected GetSimilarityMeasureGradient() method to work with vector field previously gap-overlap constraint term value was normalised by number of voxels, but gradient was not now distance map image is pre-normalised during initialisation so that both the gap-overlap constraint term and its gradient are normalised note - weighted distance map is divided by square root of number of voxels, as the two warped distance maps are mutliplied together this will normalise the gap-overlap constraint term by the number of voxels also added some debugging comments which are commented out but still in code
…dat/niftyreg.git into 28-sliding-regions Conflicts: niftyreg_build_version.txt
sliding region registrations now appear to be working, but sensible default gap-overlap constraint term weight still needs to be determined
|
Finally integrated the CI to this branch. Can you have a look? |
|
Have fixed the compilation error and successfully tested for comparable results on Windows and Linux (VM). CI-pipeline on gitlab now stuck with missing Mac-build. @mmodat can you check that you are happy once the Mac-build is complete? Thanks!!! |
|
In the meantime, some merge conflicts came up which are now solved. Can you have a look and merge, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sliding region implementation completed as presented at WBIR 2018 in Leiden, NL. References added.