Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/270 1.6.X 버전 선물하기 디자인 QA #274

Merged
merged 10 commits into from
Jul 30, 2024
Merged

Feature/270 1.6.X 버전 선물하기 디자인 QA #274

merged 10 commits into from
Jul 30, 2024

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Jul 29, 2024 •
edited
Loading

Issue

작업 내용

  • 디스코드에 올라온 QA 반영.
  • 조금 큰(?) 수정 : 선물 결제 -> 결제 완료로 넘어갈 때 reservationId + giftUuid 넘기는 대신 giftId를 넘기고 다른 API 호출하여 동일 기능 구현.

@HamBP HamBP self-assigned this Jul 29, 2024
@HamBP HamBP marked this pull request as draft July 29, 2024 05:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

Test Results

 9 files   9 suites   0s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit 819d0f4.

♻️ This comment has been updated with latest results.

@HamBP HamBP marked this pull request as ready for review July 30, 2024 09:05
@HamBP HamBP merged commit fc32cf0 into develop Jul 30, 2024
2 checks passed
@HamBP
Copy link
Member Author

HamBP commented Jul 30, 2024

엇 270 이슈를 닫아야하는데 271 이슈를 닫아버렸다... 수정할게요

@HamBP HamBP changed the title Feature/271 1.6.X 버전 선물하기 디자인 QA Feature/270 1.6.X 버전 선물하기 디자인 QA Jul 30, 2024
@HamBP HamBP deleted the feature/271 branch September 16, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HamBP HamBP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.6.0 [선물하기/공연상세] 디자인 QA 1차
1 participant
@HamBP