Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : 배너 노출 시점 변경 #295

Merged
merged 1 commit into from
Sep 22, 2024
Merged

fix : 배너 노출 시점 변경 #295

merged 1 commit into from
Sep 22, 2024

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Sep 22, 2024

Issue

작업 내용

  • 디코에서 얘기했던 코드 그대로 사용했어~
  • 실제로 등록된 공연이 0개일 가능성을 고려하면 로딩 상태 여부로 판단하는 게 가장 정확하겠지만
  • 0개일 가능성이 없기도 하고, 로딩 상태도 정의를 안 해 둬서 그냥 쉽게 갑니당

@HamBP HamBP self-assigned this Sep 22, 2024
@HamBP HamBP requested a review from mangbaam September 22, 2024 06:01
@mangbaam
Copy link
Member

LGTM
loading 으로 처리하는 게 좋지 않을 까 했는데 이미 공연 개수가 0개가 아니라서 괜찮을 듯 합니다

@github-actions GitHub Actions
Copy link

Test Results

 9 files   9 suites   0s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit 37ad363.

@HamBP HamBP merged commit fb1275f into develop Sep 22, 2024
2 checks passed
@HamBP HamBP deleted the feature/294 branch September 22, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangbaam mangbaam mangbaam approved these changes

Assignees

@HamBP HamBP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

배너 노출 시점 변경
2 participants
@HamBP @mangbaam