Feature/boolti 298 공연 상세 UI 변경 (출연진 탭 추가) #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 9 files 9 suites 0s ⏱️ Results for commit aa5734d. ♻️ This comment has been updated with latest results. |
HamBP
approved these changes
Oct 1, 2024
Comment on lines
15
to
16
| val createdAt: String = LocalDateTime.MIN.format(DateTimeFormatter.ISO_LOCAL_DATE_TIME), | ||
| val modifiedAt: String? = null, |
There was a problem hiding this comment.
이거 내 예상이 맞다면 DB 관리 차원에서 항상 들어가는 column이 같이 내려온 거 같은데, UI에서 안 쓰이면 안 받아도 될 듯!
| } | ||
|
|
||
| fun selectTab(index: Int) { | ||
| _uiState.update { it.copy(selectedTab = index.coerceIn(0 .. 1)) } |
| Column( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(vertical = 117.dp), |
There was a problem hiding this comment.
개인적으로는 패딩보다는 높이를 290으로 지정하고 가운데 정렬할 거 같긴 한데, 참고만 해주세여~
Comment on lines
+544
to
+547
| /** | ||
| * 중첩 Lazy 레이아웃 처리를 위해 높이 고정 필요 | ||
| */ | ||
| val gridHeight = memberHeight * rows + spacedBySize * (rows - 1) |
There was a problem hiding this comment.
Lazy 안에 Lazy가 있으면 높이를 계산할 수 없어서 Exception 발생해서 크래시 터져
그래서 높이를 지정해줘야 해
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용
Column→LazyColumn리팩터링UserThumbnail)UserThumbnail로 대체