Remove Content-Type Header when request with empty body POST method #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Default Client). - add Content-Length Header with 0 value when `sun.net.http.allowRestrictedHeaders` System Property is set true - fix not running test to run
jay-choe
force-pushed
the
remove-content-type-header-with-empty-post-body
branch
from
6928474
to
bbec180
Compare
jay-choe
force-pushed
the
remove-content-type-header-with-empty-post-body
branch
from
30079f9
to
21ed9eb
Compare
|
This look good. Could you please add some information to the README to indicate how to take advantage of this change, helping folks understand the System Property requirement? |
kdavisk6
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I have looked this issue and got an idea to deal with.
In current code, convert null body to not null and it write to outputstream.
In that process, when writing empty string in outputstream, unwanted Content-Type Header is added which is ''application/x-www-form-urlencoded".
So, I rearrange null body code to avoid unwanted header.
With this, Content-Length header is not set, so I added. But, this header is restricted header so 'sun.net.http.allowRestrictedHeaders' system property should be true to add content-length header.
And this property should be set before client class loaded. I guess there is no suitable way to inject restricted header to connection.
Feel Free to comment this idea. thanks.