Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #286

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Update README.md #286

merged 3 commits into from
Oct 1, 2024

Conversation

SylviaDu99
Copy link
Collaborator

@SylviaDu99 SylviaDu99 commented Sep 30, 2024

Fixes #276
Fixes #244

@MaxGhenis
Copy link
Contributor

Please drop 3.9 support while you're here: #244

Edit the initial description to link both issues: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@SylviaDu99 SylviaDu99 changed the title updated README.md Update README.md Oct 1, 2024
@SylviaDu99
Copy link
Collaborator Author

Hello @MaxGhenis, thank you for your comment. I want to make sure that I fully get what you meant since only changing the prerequisites in README.md does not solve issue #244. I believe we will be solving issue #244 when working on my other PR #267.

@MaxGhenis
Copy link
Contributor

Please fix #244 here, as #267 will take more time. It should be straightforward.

@MaxGhenis MaxGhenis merged commit a8454aa into PolicyEngine:master Oct 1, 2024
3 checks passed
@MaxGhenis
Copy link
Contributor

MaxGhenis commented Oct 1, 2024

Please link and close the two issues. For next time, following the instructions in my previous comment will do this automatically.

@anth-volk anth-volk mentioned this pull request Oct 1, 2024
@SylviaDu99 SylviaDu99 deleted the readme branch October 1, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a detailed README file Drop Python 3.9 support
2 participants