Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera position setting #364

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Fix camera position setting #364

merged 2 commits into from
Jun 6, 2024

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Jun 5, 2024

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
The camera position was not set properly when passing a custom camera dict to scene.render.

What does this PR do?
Passes resetcam=False back to plotter.show. Without this the camera position was being adjusted in the plotter.show method.

References

Closes #360

How has this PR been tested?

All tests pass, running the workflow as stated in the bug report also works. Can adjust the camera and position, save the output from Shift+C, and recreate the exact camera position with a dict.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@IgorTatarnikov IgorTatarnikov requested a review from a team June 5, 2024 16:57
@adamltyson adamltyson changed the title Fixed bug in #360 Fix camera position setting Jun 6, 2024
@adamltyson
Copy link
Member

Thanks @IgorTatarnikov!

@adamltyson adamltyson merged commit f7271bf into main Jun 6, 2024
5 of 11 checks passed
@adamltyson adamltyson deleted the bug-fix-camera-reset branch June 6, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Camera settings not applied when rendering scene
2 participants