#7954 alias analysis attempt #9213
Open
+50
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
elliottt
reviewed
Sep 17, 2024
elliottt
reviewed
Sep 25, 2024
Comment on lines
+485
to
+486
| // debug_assert!(na.pre_number != 0); | ||
| // debug_assert!(nb.pre_number != 0); |
There was a problem hiding this comment.
Does the test suite pass with these assertions uncommented? You're testing nb explicitly for being unreachable on line 491, so I'm guessing that at least that one doesn't pass?
There was a problem hiding this comment.
hi Elliot, one of the test suite failed with this assertion. Here is the summary of the test suite through local ci:
failures:
---- dominator_tree::tests::unreachable_node stdout ----
thread 'dominator_tree::tests::unreachable_node' panicked at cranelift/codegen/src/dominator_tree.rs:486:9:
assertion failed: nb.pre_number != 0
failures:
dominator_tree::tests::unreachable_node
test result: FAILED. 187 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.21s
error: test failed, to rerun pass `-p cranelift-codegen --lib`
Changes to be committed:
modified: cranelift/codegen/src/alias_analysis.rs: Use
dominator tree
modified: cranelift/codegen/src/context.rs: Use dominator tree
modified: cranelift/codegen/src/dominator_tree.rs: Fix
dominates and computes and modify logic of domination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #7954, attempted in #8535, reattempted in this pr.
Draft first for ci pipeline. Possible rebase for better commit msg