fix(menu): dropdown position with translucent status bar #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alex-fournier, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
alex-fournier
force-pushed
the
fix/menu-dropdown-position
branch
from
7e676f3
to
66b8bfd
Compare
|
In 66b8bfd, I fixed the component name of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the way the status bar height is calculated on Android. Now I use
react-native-safe-area-contextto get the top inset. The old way usingNativeModules.NativeUnimoduleProxy?.modulesConstantswas no longer working since this commit in Expo: https://github.com/expo/expo/pull/28014/filesI removed the
expo-constantsdependency as it was only used for the old way of calculating status bar height that has been removed.Motivation
The initial problem was an incorrect position of the menu under the anchor when using
anchorPosition=bottomwith a translucent status bar in Android.Related issue
#4493
Test plan
I added a test case in the example app. A menu with anchor position set to bottom. It is displayed the same, either with a status bar translucent or not.