feat: Add data commons toolkit #979
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
… into toolkit/datacommons
Wendong-Fan
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Thanks @dxmaptin 's contribution! docstring and type hint can be further polished, overall looks good to me
There was a problem hiding this comment.
seems this file need to be cleaned
| from typing import Any, Dict, List, Optional, Union | ||
|
|
||
| import datacommons | ||
| import datacommons_pandas as dc |
There was a problem hiding this comment.
the abbreviation makes it not so easy to be understood, how about use the original name?
| """ | ||
|
|
||
| @staticmethod | ||
| def query_data_commons(query_string, select_function=None): |
There was a problem hiding this comment.
missing type hint for argument and output
Comment on lines
+46
to
+47
| list: A list of dictionaries, each representing a node matching the | ||
| query conditions. |
There was a problem hiding this comment.
docstring format need to be aligned with above
| return {} | ||
|
|
||
| @staticmethod | ||
| def get_property_labels(dcids, out=True): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate DataCommons
Motivation and Context
close #935Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!