Close #351: a1int::getLong() doesn't handle all error cases

Check for LONG_MAX and LONG_MIN and throw an error if the returned value is too big.
chris2511 · Aug 30, 2024 · 1684593 · 1684593
1 parent 6777f7c
commit 1684593
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/asn1int.cpp b/lib/asn1int.cpp
@@ -137,9 +137,11 @@ const ASN1_INTEGER *a1int::get0() const
 
 long a1int::getLong() const
 {
-	long l = ASN1_INTEGER_get(get0());
-	openssl_error();
-	return l;
+	int64_t value;
+	int r = ASN1_INTEGER_get_int64(&value,get0());
+	if (r == 0 || value > LONG_MAX || value < LONG_MIN)
+		throw errorEx(QString("ASN1 Integer: Failed to convert %1 to long").arg(toDec()));
+	return (long)value;
 }
 
 a1int &a1int::operator ++ (void)