use pyproject.toml #142
Draft
use pyproject.toml #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2024
|
Is it mandatory to have ci look for a requirements.txt using the .toml technique? |
The toml should include deps; I personally prefer to keep the pyproject.toml separate from tox / testing, like I did here: https://github.com/dakk/qlasskit/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the modern .toml file approach for package setup and build.
In the requirements it is possible to set the platform for which a package must be installed.
Thus, for GDAL (macos) == 3.9.2, for GDAL(linux) == 3.6.4, which fixes the gdal problem.
The build seems to work on my end on Mac OS.
Please try it and update ci as I'm not familiar with this yet.