Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add setVault to note trait template #3501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hikchoi
Copy link
Contributor

@hikchoi hikchoi commented Sep 9, 2022

chore: add setVault to note trait template

This PR:

  • adds the new setVault onCreate method as an example to the note trait template

@jonathanyeung
Copy link
Contributor

Hmm, I kinda don't want to expose this until we have a further discussion on this part of the API (I know we already released it though).

@hikchoi
Copy link
Contributor Author

hikchoi commented Sep 9, 2022

Hmm, I kinda don't want to expose this until we have a further discussion on this part of the API (I know we already released it though).

Hmm... do we want to omit it from the release notes too then?

Since note traits is an alpha feature, I think changes are fair game. Just a matter of deciding if we want users to try them out at this point. I don't really have strong opinions for/against

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants