Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating image-labler GitHub Action #3952

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dysbulic
Copy link

@dysbulic dysbulic commented Oct 3, 2023

The task that runs when a new issue is opened, issue-labler, is powered by an Action that's three years out of date & relies on Node v12. GitHub Actions no longer supports Node v12, forces the Action to run on v16.

The actual error that is causing the task to fail though is attempting an HTTP DELETE on https://api.github.com/repos/dendronhq/dendron/issues/3950/labels/scope.schema which returns HTTP 404 where #3950 was the issue I created, and it never had the scope.schema tag, nor should it have had.

All this code does is upgrade the version of issue-labler & changes how the GitHub token is accessed to match the documentation. My hopes are that the new plugin will handle deleting a non-existent tag more gracefully. (That & not want to run on Node v12.)

I can't really test this without deploying it. In fact it has to be in master for the issue-labler to run, so I should set this up on a separate repo & see if it works…

Pull Request Checklist

First Time Specifics

  • if its your first pull request to Dendron, watch out for the CLA bot that will ask you to agree to Dendron's CLA
  • if its your first pull request and you're on our Discord, add your discord handle so that we can award you the horticulturalist role when the PR is merged

I'm @dysbulic.

Commit

  • make sure your branch names adhere to our branch style
  • make sure the commit message follows Dendron's commit style
  • if this pull request is addressing an existing issue, make sure to link this PR to the issue that it is resolving.

Code

  • code should follow Code Conventions
  • sticking to existing conventions instead of creating new ones

Tests

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR (NOTE: submit the PR against the dev branch of the dendron-site repo)

  • does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants