Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Right pane height is too tall #50

Open
1 task
nzakas opened this issue Sep 27, 2024 · 3 comments · May be fixed by #55
Open
1 task

Bug: Right pane height is too tall #50

nzakas opened this issue Sep 27, 2024 · 3 comments · May be fixed by #55
Assignees
@amareshsm
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working repro:needed This issue should include a reproducible example

Comments

@nzakas
Copy link
Member

nzakas commented Sep 27, 2024 •
edited
Loading

What did you do?

Viewed the AST tree and expanded as far as I could. (This also happens in Scope view.)

What did you expect to happen?

The scrollbar goes off the bottom of the screen and there is no space between the last tree item and bottom of the screen.

What actually happened?

Image

(Looks like maybe the vertical sizing of the right panel is incorrect because the scrollbar is being cut off at the bottom?)

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@nzakas nzakas added bug Something isn't working repro:needed This issue should include a reproducible example labels Sep 27, 2024
@nzakas nzakas changed the title Bug: Missing space on top of first tree item Bug: Missing space on top of first tree item and bottom of last tree item Sep 27, 2024
@nzakas nzakas added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 27, 2024
@nzakas nzakas changed the title Bug: Missing space on top of first tree item and bottom of last tree item Bug: Right pane height is too tall Sep 27, 2024
@nzakas
Copy link
Member Author

nzakas commented Sep 27, 2024

Actually, it looks like the left pane has the same problem:
Image

@nzakas
Copy link
Member Author

nzakas commented Sep 27, 2024

It looks like this is at least partly related to the border at the top of the page. We probably need to revisit how the page layout is structured.

@amareshsm
Copy link
Member

amareshsm commented Sep 27, 2024 •
edited
Loading

It looks like this is at least partly related to the border at the top of the page. We probably need to revisit how the page layout is structured.

We need to update the layout height calculation part. I will look into this issue.
Image

@amareshsm amareshsm self-assigned this Sep 27, 2024
@amareshsm amareshsm linked a pull request Sep 30, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amareshsm amareshsm

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working repro:needed This issue should include a reproducible example
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: panel height issue eslint/code-explorer
2 participants
@nzakas @amareshsm