Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panel height issue #55

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: panel height issue #55

wants to merge 4 commits into from

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

  1. Set the same height (calc(100vh - 80px)) for both the right and left panels to be consistent.
  2. Added padding to the bottom of the accordions to create some space at the end.

Related Issues

Fixes #50

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Sep 30, 2024
@amareshsm amareshsm marked this pull request as ready for review September 30, 2024 15:22
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit e3b6e19
🔍 Latest deploy log https://app.netlify.com/sites/eslint-code-explorer/deploys/66fc3cfd8cd214000897bad2
😎 Deploy Preview https://deploy-preview-55--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas
Copy link
Member

nzakas commented Sep 30, 2024

It looks like the height of the left pane scrollbar is a bit too short.
Screenshot 2024-09-30 at 11-43-14 ESLint Code Explorer

@nzakas
Copy link
Member

nzakas commented Oct 1, 2024

@amareshsm every time you merge with main it generates a notification, so please do so sparingly. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Right pane height is too tall
2 participants