daos: Avoid double quotes for string literals #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They use invalid syntax (see the following commit) and were never used.
✅ Deploy Preview for selfoss canceled.
|
SQLite (https://www.sqlite.org/quirks.html#dblquote), MySQL (https://dev.mysql.com/doc/refman/5.7/en/string-literals.html) but not PostgreSQL (https://dev.mysql.com/doc/refman/5.7/en/string-literals.html) support using double quotes for string literals in some places. This is generally considered a bad practice and SQLite recommends disabling the feature: https://www.sqlite.org/compile.html#recommended_compile_time_options which FreeBSD does, resulting in an error on startup: no such column: table Let’s fix the syntax to use ANSI SQL quoting style.
jtojnar
force-pushed
the
sqlite-string-literals
branch
from
d810e06
to
7ba724a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite, MySQL but not PostgreSQL support using double quotes for string literals in some places. This is generally considered a bad practice and SQLite recommends disabling the feature, which FreeBSD does, resulting in an error on startup:
Let’s fix the syntax to use ANSI SQL quoting style.
Fixes: #1488