Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rename core to common #8

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat!: rename core to common #8

merged 1 commit into from
Jun 12, 2024

Conversation

korikuzma
Copy link
Contributor

close #4

@korikuzma korikuzma requested a review from larrybabb June 12, 2024 15:38
@korikuzma korikuzma self-assigned this Jun 12, 2024
korikuzma
korikuzma commented Jun 12, 2024
View reviewed changes
schema/gks-common/common-source.yaml
$id: "https://w3id.org/ga4gh/schema/gks-common/1.x/core-source.yaml"
title: GKS Common Library Core Definitions
$id: "https://w3id.org/ga4gh/schema/gks-common/1.x/common-source.yaml"
title: GKS Common Library Definitions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to keep core?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not here. Matt only want's to use the term core in reference to the core-im in va-spec.

@korikuzma korikuzma mentioned this pull request Jun 12, 2024
Closed
larrybabb
larrybabb approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

schema/gks-common/common-source.yaml
$id: "https://w3id.org/ga4gh/schema/gks-common/1.x/core-source.yaml"
title: GKS Common Library Core Definitions
$id: "https://w3id.org/ga4gh/schema/gks-common/1.x/common-source.yaml"
title: GKS Common Library Definitions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not here. Matt only want's to use the term core in reference to the core-im in va-spec.

@larrybabb larrybabb merged commit e290c08 into 1.x Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larrybabb larrybabb larrybabb approved these changes

Assignees

@korikuzma korikuzma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change name of core-source.yaml to common-source.yaml
2 participants
@korikuzma @larrybabb