New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NF,DOC improve docstring for show and make_static #548

Merged

mvdoc merged 2 commits into gallantlab:main from mvdoc:enh/viewers

Jul 19, 2024

Contributor

mvdoc commented Jul 19, 2024 •

edited

Loading

This PR

reorganizes the order of the kwargs for both cortex.webgl.view.show and cortex.webgl.view.make_static so that they match the docstring
improves the docstring for both functions
allows passing curvature_{brightness,contrast,curvature} to make_static too
adds a new keyword surface_specularity in both functions to allow disabling that hideous surface specularity 😝
removes the cmap kwarg since it doesn't do anything anymore

mvdoc added 2 commits

July 19, 2024 06:12


          NF,DOC improve docstring for view and make_static

4da0abb


          Remove cmap kwarg since it doesn't do anything

de641e3

mvdoc merged commit 6237fe3 into gallantlab:main

9 checks passed

mvdoc deleted the enh/viewers branch

July 19, 2024 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet