Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net_lwip_webserver example fix and improvement #2829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HiFiPhile
Copy link
Collaborator

@HiFiPhile HiFiPhile commented Oct 5, 2024

Describe the PR

  • service_traffic: Don't call pbuf_free when ethernet_input is Ok
  • Add MSOS 2.0 descriptor to auto load NCM driver on Windows 10.

@HiFiPhile HiFiPhile changed the title net_lwip_webserver example fix and improment net_lwip_webserver example fix and improvement Oct 5, 2024
@Slion
Copy link

Slion commented Oct 5, 2024

What's the benefit of the NCM changes? I'm currently using NCM on Windows and it's been working fine.

@HiFiPhile
Copy link
Collaborator Author

What's the benefit of the NCM changes? I'm currently using NCM on Windows and it's been working fine.

On Windows 10 you have to manually install NCM driver from device manager.

@Slion
Copy link

Slion commented Oct 5, 2024

On Windows 10 you have to manually install NCM driver from device manager.

I see, I only used it on Windows 11 so far and I did not need to install drivers.

@Slion
Copy link

Slion commented Oct 5, 2024

We may want to add comments in code to explain that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants