Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update codec #1524

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: update codec #1524

wants to merge 1 commit into from
+740 −79

Conversation

hugocaillard
Copy link
Collaborator

Mostly code pulled from stacks-core

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 477 lines in your changes missing coverage. Please review.

Files Patch % Lines
components/stacks-codec/src/codec.rs 0.00% 477 Missing ⚠️

📢 Thoughts on this report? Let us know!

obycode
obycode approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm curious if we could instead refactor the code in stacks-core and just directly import a crate for this?

@hugocaillard hugocaillard mentioned this pull request Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode obycode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugocaillard @obycode