-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin-hubtype-analytics: Add target bot_interaction_id on feedback knowledge base events #2877
Merged
Iru89
merged 13 commits into
master-lts
from
BLT-971-add-target-bot-interaction-id-of-feedback-events-to-point-to-bot-interaction-id-plugin
Jul 29, 2024
Merged
plugin-hubtype-analytics: Add target bot_interaction_id on feedback knowledge base events #2877
Iru89
merged 13 commits into
master-lts
from
BLT-971-add-target-bot-interaction-id-of-feedback-events-to-point-to-bot-interaction-id-plugin
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
changed the title
Blt 971 add target bot interaction id of feedback events to point to bot interaction id plugin
plugin-hubtype-analytics: Add target bot_interaction_id on feedback knowledge base events
Jul 22, 2024
Iru89
force-pushed
the
BLT-971-add-target-bot-interaction-id-of-feedback-events-to-point-to-bot-interaction-id-plugin
branch
2 times, most recently
from
July 22, 2024 13:43
a18bc48
to
16ebc0a
Compare
vanbasten17
approved these changes
Jul 22, 2024
packages/botonic-plugin-hubtype-analytics/src/event-models/ht-event-webview-end.ts
Outdated
Show resolved
Hide resolved
packages/botonic-plugin-hubtype-analytics/src/event-models/ht-event-webview-step.ts
Outdated
Show resolved
Hide resolved
CarlosELorenzo
approved these changes
Jul 24, 2024
AinaVendrell
approved these changes
Jul 24, 2024
…owledge base event
…_interaction_id in test
…lder withBotEvent
…bviewStepNumber are called the same to create EventWebviewStep and EventWebviewEnd events
Iru89
force-pushed
the
BLT-971-add-target-bot-interaction-id-of-feedback-events-to-point-to-bot-interaction-id-plugin
branch
from
July 29, 2024 13:17
861748b
to
d040404
Compare
Iru89
deleted the
BLT-971-add-target-bot-interaction-id-of-feedback-events-to-point-to-bot-interaction-id-plugin
branch
July 29, 2024 13:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@botonic/core
Add a new bot_interaction_id attribute in request.input.
Add bot_interaction_id in HandoffBuilder.withBotEvent
@botonic/react
Be able to store in a Text message the value of botInteractionId. Use the value of botInteractionId when creating a feedback_knowledge_base event
@botonic/plugin-flow-builder
When create a Text message using a knowledge base, add the attribute of botInteractionId
@botonic/plugin-hubtype-analytics
Add in feedback_knowledge_base event the attribute feedback_target_bot_interaction_id
Refactor and split Webviews events in 2 classes and also add optionals attributes
Context
This new attribute is needed in the knowledge base feedback events.
Testing
Fix tests of @botonic/core, @botonic/plugin-flow-builder, @botnic/plugin-flow-builder adding bot_interaction_id in Input tests
Add feedback_target_bot_interaction_id in feedback_knowledge_base test